Organize/consolidate inlay hint tests#55332
Merged
MariaSolOs merged 2 commits intomicrosoft:mainfrom Aug 14, 2023
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
jakebailey
approved these changes
Aug 14, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Seems okay to me though I don't have a strong opinion about the baselines for a feature I didn't write the code for 😄
andrewbranch
approved these changes
Aug 14, 2023
Member
|
This got merged without the tests passing, so main is currently broken. |
MariaSolOs
added a commit
that referenced
this pull request
Aug 14, 2023
This reverts commit 05cb53e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make #55141 easier to test, I first wanted to reorganize the existing test suite into a smaller set of files with more descriptive file names.