Fixed an issue with top function type being callable with no arguments by Andarist · Pull Request #52387 · microsoft/TypeScript

Andarist · 2023-01-24T10:16:31Z

fixes #48840
reverts a part of https://github.com/microsoft/TypeScript/pull/35438/files (the tests added there still pass)

Andarist · 2023-01-24T10:18:43Z

This has been labeled as "For Uncommitted Bug" but the associated issue is labeled with "Bug". This perhaps indicates a bug in the bot.

fatcerberus · 2023-01-28T16:00:36Z

I always thought “For Uncommitted Bug” was literal: the issue has a Bug label but not a Committed label (note: not the same thing as “commit” in git terminology)

Andarist · 2023-01-28T16:08:44Z

Hm, i think it also gets For Uncommitted Bug if the issue has no label - and that’s what i assumed to be the main differentiator here. U might be right though - maybe it has to be assigned to a milestone (specific TS version or Backlog) for this label to not be added to the PR

jakebailey · 2023-01-30T04:06:41Z

My understanding is that this particular label is mainly about whether or not it has been assigned to a milestone.

sandersn · 2023-02-01T23:19:37Z

@DanielRosenwasser or @jakebailey can you figure out if #48840 should be moved into the backlog or a specific milestone? I know the bug came up in the recent design meeting, but I don't think we decided whether the bug was worth fixing.

jakebailey · 2023-02-01T23:20:04Z

I think I'd like to see @ahejlsberg take a look at this in context of #52282 too, lest we end up with a surprising relation behavior.

jakebailey · 2023-03-01T05:56:19Z

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-03-01T05:56:22Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-01T05:56:22Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 0f8d091. You can monitor the build here.

typescript-bot · 2023-03-01T05:56:22Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0f8d091. You can monitor the build here.

typescript-bot · 2023-03-01T05:56:22Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-01T05:56:22Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 0f8d091. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-01T06:07:57Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52387/merge:

Everything looks good!

typescript-bot · 2023-03-01T07:12:45Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52387

_Metric	_main	₅₂₃₈₇	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,738k (± 0.02%)}	_{359,802k (± 0.01%)}	_~	_359,761k	_359,852k	_{p=0.128 n=6}
_{Parse Time}	_{3.51s (± 0.93%)}	_{3.50s (± 0.47%)}	_~	_3.47s	_3.51s	_{p=0.572 n=6}
_{Bind Time}	_{1.13s (± 0.46%)}	_{1.13s (± 0.00%)}	_~	_1.13s	_1.13s	_{p=0.174 n=6}
_{Check Time}	_{8.69s (± 0.38%)}	_{8.64s (± 0.64%)}	_~	_8.59s	_8.71s	_{p=0.170 n=6}
_{Emit Time}	_{7.45s (± 0.36%)}	_{7.43s (± 0.78%)}	_~	_7.38s	_7.54s	_{p=0.170 n=6}
_{Total Time}	_{20.78s (± 0.36%)}	_{20.70s (± 0.48%)}	_~	_20.58s	_20.86s	_{p=0.093 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,469k (± 1.57%)}	_{192,404k (± 1.58%)}	_~	_189,529k	_195,242k	_{p=0.471 n=6}
_{Parse Time}	_{1.49s (± 0.69%)}	_{1.47s (± 0.71%)}	_~	_1.46s	_1.49s	_{p=0.098 n=6}
_{Bind Time}	_{0.77s (± 0.53%)}	_{0.76s (± 1.07%)}	_{-0.01s (- 1.08%)}	_0.76s	_0.78s	_{p=0.038 n=6}
_{Check Time}	_{9.35s (± 0.85%)}	_{9.28s (± 0.69%)}	_~	_9.19s	_9.36s	_{p=0.124 n=6}
_{Emit Time}	_{2.72s (± 0.49%)}	_{2.73s (± 0.76%)}	_~	_2.70s	_2.76s	_{p=0.934 n=6}
_{Total Time}	_{14.33s (± 0.60%)}	_{14.24s (± 0.33%)}	_~	_14.19s	_14.32s	_{p=0.104 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,859k (± 0.01%)}	_{343,861k (± 0.01%)}	_~	_343,826k	_343,933k	_{p=1.000 n=6}
_{Parse Time}	_{2.64s (± 1.54%)}	_{2.63s (± 1.04%)}	_~	_2.60s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{1.01s (± 0.40%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.114 n=6}
_{Check Time}	_{7.04s (± 0.54%)}	_{7.02s (± 0.57%)}	_~	_6.96s	_7.07s	_{p=0.748 n=6}
_{Emit Time}	_{4.24s (± 0.80%)}	_{4.24s (± 0.85%)}	_~	_4.20s	_4.30s	_{p=0.687 n=6}
_{Total Time}	_{14.93s (± 0.51%)}	_{14.90s (± 0.44%)}	_~	_14.81s	_15.01s	_{p=0.687 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{299,885k (± 0.01%)}	_{299,886k (± 0.01%)}	_~	_299,854k	_299,942k	_{p=0.689 n=6}
_{Parse Time}	_{2.04s (± 1.37%)}	_{2.04s (± 1.19%)}	_~	_2.00s	_2.07s	_{p=0.870 n=6}
_{Bind Time}	_{1.14s (± 0.36%)}	_{1.13s (± 0.46%)}	_~	_1.13s	_1.14s	_{p=0.112 n=6}
_{Check Time}	_{6.53s (± 0.46%)}	_{6.52s (± 0.58%)}	_~	_6.47s	_6.57s	_{p=0.628 n=6}
_{Emit Time}	_{3.86s (± 1.11%)}	_{3.83s (± 0.88%)}	_~	_3.80s	_3.89s	_{p=0.225 n=6}
_{Total Time}	_{13.57s (± 0.47%)}	_{13.53s (± 0.63%)}	_~	_13.45s	_13.64s	_{p=0.261 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,404k (± 0.00%)}	_{476,424k (± 0.00%)}	_~	_476,391k	_476,449k	_{p=0.173 n=6}
_{Parse Time}	_{3.13s (± 0.48%)}	_{3.12s (± 0.71%)}	_~	_3.09s	_3.15s	_{p=0.188 n=6}
_{Bind Time}	_{0.92s (± 1.15%)}	_{0.91s (± 0.57%)}	_~	_0.90s	_0.91s	_{p=0.142 n=6}
_{Check Time}	_{17.07s (± 0.49%)}	_{17.03s (± 0.46%)}	_~	_16.96s	_17.15s	_{p=0.520 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.12s (± 0.37%)}	_{21.06s (± 0.37%)}	_~	_20.99s	_21.18s	_{p=0.376 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,111k (± 0.02%)}	_{548,027k (± 0.02%)}	_~	_547,875k	_548,187k	_{p=0.298 n=6}
_{Parse Time}	_{4.08s (± 0.53%)}	_{4.07s (± 0.65%)}	_~	_4.04s	_4.11s	_{p=0.687 n=6}
_{Bind Time}	_{1.67s (± 0.38%)}	_{1.68s (± 0.87%)}	_~	_1.66s	_1.70s	_{p=0.156 n=6}
_{Check Time}	_{2.75s (± 1.07%)}	_{2.76s (± 1.00%)}	_~	_2.72s	_2.79s	_{p=0.687 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{8.59s (± 0.51%)}	_{8.60s (± 0.47%)}	_~	_8.52s	_8.63s	_{p=0.334 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,079k (± 0.00%)}	_{359,085k (± 0.01%)}	_~	_359,051k	_359,178k	_{p=0.423 n=6}
_{Parse Time}	_{3.73s (± 0.31%)}	_{3.73s (± 0.50%)}	_~	_3.71s	_3.76s	_{p=0.287 n=6}
_{Bind Time}	_{1.20s (± 0.34%)}	_{1.19s (± 0.68%)}	_~	_1.18s	_1.20s	_{p=0.248 n=6}
_{Check Time}	_{9.46s (± 0.25%)}	_{9.46s (± 0.22%)}	_~	_9.43s	_9.49s	_{p=0.935 n=6}
_{Emit Time}	_{7.90s (± 0.64%)}	_{7.93s (± 0.67%)}	_~	_7.87s	_8.03s	_{p=0.295 n=6}
_{Total Time}	_{22.28s (± 0.17%)}	_{22.31s (± 0.31%)}	_~	_22.24s	_22.44s	_{p=0.747 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,371k (± 0.92%)}	_{191,319k (± 0.03%)}	_~	_191,246k	_191,418k	_{p=0.471 n=6}
_{Parse Time}	_{1.58s (± 0.84%)}	_{1.57s (± 0.52%)}	_~	_1.56s	_1.58s	_{p=0.198 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.82s (± 0.00%)}	_{-0.01s (- 0.81%)}	_0.82s	_0.82s	_{p=0.025 n=6}
_{Check Time}	_{10.07s (± 0.70%)}	_{10.10s (± 0.89%)}	_~	_9.98s	_10.21s	_{p=0.470 n=6}
_{Emit Time}	_{2.99s (± 0.65%)}	_{3.00s (± 0.83%)}	_~	_2.97s	_3.03s	_{p=0.517 n=6}
_{Total Time}	_{15.47s (± 0.53%)}	_{15.50s (± 0.75%)}	_~	_15.34s	_15.65s	_{p=0.628 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,125k (± 0.01%)}	_{343,140k (± 0.00%)}	_~	_343,116k	_343,163k	_{p=0.229 n=6}
_{Parse Time}	_{2.80s (± 0.57%)}	_{2.79s (± 0.23%)}	_~	_2.78s	_2.80s	_{p=0.179 n=6}
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.08s (± 0.97%)}	_~	_1.06s	_1.09s	_{p=0.142 n=6}
_{Check Time}	_{7.70s (± 0.28%)}	_{7.68s (± 0.49%)}	_~	_7.63s	_7.72s	_{p=0.573 n=6}
_{Emit Time}	_{4.43s (± 0.55%)}	_{4.41s (± 0.97%)}	_~	_4.37s	_4.49s	_{p=0.196 n=6}
_{Total Time}	_{16.02s (± 0.20%)}	_{15.96s (± 0.39%)}	_~	_15.90s	_16.07s	_{p=0.092 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,263k (± 0.00%)}	_{299,246k (± 0.01%)}	_~	_299,215k	_299,292k	_{p=0.128 n=6}
_{Parse Time}	_{2.16s (± 0.68%)}	_{2.17s (± 0.85%)}	_~	_2.15s	_2.19s	_{p=0.367 n=6}
_{Bind Time}	_{1.24s (± 0.67%)}	_{1.24s (± 1.35%)}	_~	_1.21s	_1.26s	_{p=0.612 n=6}
_{Check Time}	_{7.20s (± 0.43%)}	_{7.18s (± 0.35%)}	_~	_7.15s	_7.21s	_{p=0.333 n=6}
_{Emit Time}	_{4.33s (± 0.54%)}	_{4.31s (± 0.46%)}	_~	_4.29s	_4.34s	_{p=0.413 n=6}
_{Total Time}	_{14.93s (± 0.21%)}	_{14.90s (± 0.17%)}	_~	_14.86s	_14.93s	_{p=0.127 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,661k (± 0.00%)}	_{475,648k (± 0.00%)}	_~	_475,622k	_475,668k	_{p=0.229 n=6}
_{Parse Time}	_{3.30s (± 0.38%)}	_{3.29s (± 0.64%)}	_~	_3.27s	_3.33s	_{p=0.157 n=6}
_{Bind Time}	_{0.96s (± 0.78%)}	_{0.96s (± 0.00%)}	_~	_0.96s	_0.96s	_{p=0.598 n=6}
_{Check Time}	_{18.19s (± 0.60%)}	_{18.05s (± 0.39%)}	_{-0.14s (- 0.74%)}	_17.99s	_18.15s	_{p=0.044 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.45s (± 0.52%)}	_{22.30s (± 0.38%)}	_~	_22.23s	_22.42s	_{p=0.054 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{545,758k (± 0.03%)}	_{545,727k (± 0.01%)}	_~	_545,638k	_545,823k	_{p=0.873 n=6}
_{Parse Time}	_{4.29s (± 0.42%)}	_{4.28s (± 0.58%)}	_~	_4.25s	_4.31s	_{p=0.421 n=6}
_{Bind Time}	_{1.77s (± 0.58%)}	_{1.76s (± 0.36%)}	_~	_1.75s	_1.77s	_{p=0.293 n=6}
_{Check Time}	_{2.98s (± 0.69%)}	_{2.99s (± 0.46%)}	_~	_2.97s	_3.01s	_{p=0.454 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.13s (± 0.38%)}	_{9.11s (± 0.39%)}	_~	_9.08s	_9.16s	_{p=0.333 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,821k (± 0.00%)}	_{352,815k (± 0.00%)}	_~	_352,786k	_352,829k	_{p=0.936 n=6}
_{Parse Time}	_{3.73s (± 0.81%)}	_{3.69s (± 0.57%)}	_~	_3.66s	_3.71s	_{p=0.064 n=6}
_{Bind Time}	_{1.25s (± 0.44%)}	_{1.24s (± 0.33%)}	_~	_1.24s	_1.25s	_{p=0.282 n=6}
_{Check Time}	_{9.76s (± 0.57%)}	_{9.71s (± 0.59%)}	_~	_9.64s	_9.78s	_{p=0.195 n=6}
_{Emit Time}	_{8.39s (± 1.06%)}	_{8.38s (± 0.66%)}	_~	_8.29s	_8.46s	_{p=0.936 n=6}
_{Total Time}	_{23.13s (± 0.24%)}	_{23.01s (± 0.20%)}	_{-0.12s (- 0.50%)}	_22.93s	_23.07s	_{p=0.010 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{186,539k (± 0.02%)}	_{186,555k (± 0.01%)}	_~	_186,532k	_186,571k	_{p=0.378 n=6}
_{Parse Time}	_{1.58s (± 0.33%)}	_{1.56s (± 0.48%)}	_{-0.02s (- 0.95%)}	_1.55s	_1.57s	_{p=0.010 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{0.84s (± 0.00%)}	_~	_0.84s	_0.84s	_{p=0.073 n=6}
_{Check Time}	_{10.20s (± 0.63%)}	_{10.21s (± 0.58%)}	_~	_10.11s	_10.27s	_{p=1.000 n=6}
_{Emit Time}	_{3.13s (± 0.53%)}	_{3.12s (± 0.71%)}	_~	_3.09s	_3.15s	_{p=0.682 n=6}
_{Total Time}	_{15.75s (± 0.50%)}	_{15.72s (± 0.43%)}	_~	_15.63s	_15.83s	_{p=0.378 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,119k (± 0.00%)}	_{338,145k (± 0.01%)}	_~	_338,103k	_338,186k	_{p=0.065 n=6}
_{Parse Time}	_{2.89s (± 0.56%)}	_{2.88s (± 0.61%)}	_~	_2.86s	_2.90s	_{p=0.104 n=6}
_{Bind Time}	_{1.10s (± 0.74%)}	_{1.10s (± 0.37%)}	_~	_1.09s	_1.10s	_{p=0.206 n=6}
_{Check Time}	_{8.13s (± 0.76%)}	_{8.07s (± 0.30%)}	_~	_8.04s	_8.10s	_{p=0.092 n=6}
_{Emit Time}	_{4.70s (± 1.05%)}	_{4.67s (± 0.57%)}	_~	_4.64s	_4.72s	_{p=0.421 n=6}
_{Total Time}	_{16.83s (± 0.67%)}	_{16.71s (± 0.31%)}	_~	_16.67s	_16.81s	_{p=0.054 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,285k (± 0.00%)}	_{294,270k (± 0.01%)}	_~	_294,244k	_294,296k	_{p=0.093 n=6}
_{Parse Time}	_{2.38s (± 0.51%)}	_{2.37s (± 0.79%)}	_~	_2.35s	_2.39s	_{p=0.164 n=6}
_{Bind Time}	_{1.07s (± 0.70%)}	_{1.06s (± 0.49%)}	_~	_1.06s	_1.07s	_{p=0.069 n=6}
_{Check Time}	_{7.49s (± 0.36%)}	_{7.45s (± 0.61%)}	_~	_7.39s	_7.51s	_{p=0.106 n=6}
_{Emit Time}	_{4.31s (± 0.68%)}	_{4.26s (± 0.69%)}	_{-0.05s (- 1.16%)}	_4.21s	_4.30s	_{p=0.019 n=6}
_{Total Time}	_{15.26s (± 0.18%)}	_{15.14s (± 0.39%)}	_{-0.12s (- 0.80%)}	_15.06s	_15.21s	_{p=0.005 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,334k (± 0.00%)}	_{471,337k (± 0.01%)}	_~	_471,279k	_471,386k	_{p=0.748 n=6}
_{Parse Time}	_{3.46s (± 0.38%)}	_{3.44s (± 0.51%)}	_~	_3.43s	_3.47s	_{p=0.118 n=6}
_{Bind Time}	_{1.01s (± 0.51%)}	_{1.00s (± 0.81%)}	_~	_0.99s	_1.01s	_{p=0.523 n=6}
_{Check Time}	_{19.00s (± 0.62%)}	_{18.97s (± 1.01%)}	_~	_18.82s	_19.31s	_{p=0.521 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.47s (± 0.50%)}	_{23.42s (± 0.85%)}	_~	_23.26s	_23.78s	_{p=0.332 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,383k (± 0.00%)}	_{534,393k (± 0.00%)}	_~	_534,366k	_534,422k	_{p=0.809 n=6}
_{Parse Time}	_{4.50s (± 1.56%)}	_{4.43s (± 1.06%)}	_~	_4.39s	_4.52s	_{p=0.076 n=6}
_{Bind Time}	_{1.73s (± 4.31%)}	_{1.76s (± 2.88%)}	_~	_1.66s	_1.79s	_{p=0.744 n=6}
_{Check Time}	_{3.14s (± 0.44%)}	_{3.13s (± 0.62%)}	_~	_3.10s	_3.15s	_{p=0.869 n=6}
_{Emit Time}	_{0.10s (± 0.00%)}	_{0.10s (± 0.00%)}	_~	_0.10s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{9.48s (± 0.50%)}	_{9.43s (± 0.37%)}	_~	_9.37s	_9.46s	_{p=0.147 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₈₇	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52387

_Metric	_main	₅₂₃₈₇	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,364ms (± 0.45%)}	_{2,366ms (± 1.07%)}	_~	_2,342ms	_2,407ms	_{p=0.809 n=6}
_{Req 2 - geterr}	_{5,312ms (± 0.49%)}	_{5,293ms (± 0.79%)}	_~	_5,239ms	_5,346ms	_{p=0.378 n=6}
_{Req 3 - references}	_{338ms (± 0.76%)}	_{336ms (± 0.94%)}	_~	_333ms	_342ms	_{p=0.220 n=6}
_{Req 4 - navto}	_{285ms (± 0.36%)}	_{285ms (± 1.01%)}	_~	_279ms	_287ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 4.81%)}	_{79ms (± 5.38%)}	_~	_77ms	_88ms	_{p=0.188 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,531ms (± 0.81%)}	_{2,516ms (± 1.33%)}	_~	_2,463ms	_2,561ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{3,996ms (± 0.47%)}	_{3,994ms (± 0.67%)}	_~	_3,971ms	_4,045ms	_{p=0.575 n=6}
_{Req 3 - references}	_{353ms (± 0.71%)}	_{353ms (± 0.64%)}	_~	_351ms	_357ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{293ms (± 0.66%)}	_{293ms (± 0.36%)}	_~	_291ms	_294ms	_{p=0.742 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.60%)}	_{68ms (± 0.93%)}	_~	_67ms	_69ms	_{p=0.673 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,190ms (± 0.48%)}	_{3,171ms (± 0.73%)}	_~	_3,139ms	_3,199ms	_{p=0.228 n=6}
_{Req 2 - geterr}	_{1,607ms (± 0.66%)}	_{1,600ms (± 0.61%)}	_~	_1,592ms	_1,618ms	_{p=0.297 n=6}
_{Req 3 - references}	_{104ms (± 1.44%)}	_{104ms (± 1.42%)}	_~	_102ms	_106ms	_{p=0.615 n=6}
_{Req 4 - navto}	_{360ms (± 0.62%)}	_{358ms (± 0.49%)}	_~	_356ms	_361ms	_{p=0.128 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{432ms (± 0.59%)}	_{426ms (± 1.41%)}	_~	_421ms	_438ms	_{p=0.065 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,491ms (± 1.58%)}	_{2,491ms (± 1.63%)}	_~	_2,450ms	_2,550ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,747ms (± 1.04%)}	_{5,716ms (± 0.48%)}	_~	_5,673ms	_5,754ms	_{p=0.298 n=6}
_{Req 3 - references}	_{349ms (± 0.54%)}	_{348ms (± 0.39%)}	_~	_346ms	_350ms	_{p=0.510 n=6}
_{Req 4 - navto}	_{281ms (± 0.52%)}	_{280ms (± 0.49%)}	_~	_278ms	_282ms	_{p=0.118 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 0.49%)}	_{84ms (± 0.89%)}	_~	_83ms	_85ms	_{p=0.389 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,688ms (± 0.60%)}	_{2,678ms (± 0.44%)}	_~	_2,665ms	_2,693ms	_{p=0.226 n=6}
_{Req 2 - geterr}	_{4,356ms (± 0.47%)}	_{4,354ms (± 0.59%)}	_~	_4,306ms	_4,375ms	_{p=1.000 n=6}
_{Req 3 - references}	_{365ms (± 0.81%)}	_{364ms (± 1.07%)}	_~	_359ms	_369ms	_{p=0.809 n=6}
_{Req 4 - navto}	_{289ms (± 0.48%)}	_{286ms (± 1.12%)}	_~	_283ms	_291ms	_{p=0.250 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 1.14%)}	_{73ms (± 0.70%)}	_~	_73ms	_74ms	_{p=0.533 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,339ms (± 0.50%)}	_{3,326ms (± 0.29%)}	_~	_3,316ms	_3,341ms	_{p=0.109 n=6}
_{Req 2 - geterr}	_{1,777ms (± 1.35%)}	_{1,761ms (± 1.37%)}	_~	_1,743ms	_1,808ms	_{p=0.229 n=6}
_{Req 3 - references}	_{112ms (± 2.28%)}	_{111ms (± 1.76%)}	_~	_109ms	_114ms	_{p=0.625 n=6}
_{Req 4 - navto}	_{344ms (± 1.32%)}	_{345ms (± 1.45%)}	_~	_338ms	_352ms	_{p=0.936 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{435ms (± 0.92%)}	_{433ms (± 0.93%)}	_~	_426ms	_437ms	_{p=0.568 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,570ms (± 0.64%)}	_{2,570ms (± 0.56%)}	_~	_2,550ms	_2,584ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{6,038ms (± 0.70%)}	_{6,022ms (± 0.83%)}	_~	_5,980ms	_6,108ms	_{p=0.471 n=6}
_{Req 3 - references}	_{368ms (± 0.97%)}	_{364ms (± 0.75%)}	_~	_360ms	_367ms	_{p=0.164 n=6}
_{Req 4 - navto}	_{277ms (± 1.26%)}	_{274ms (± 0.43%)}	_{-3ms (- 1.08%)}	_273ms	_276ms	_{p=0.032 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (± 1.87%)}	_{100ms (± 1.87%)}	_~	_96ms	_101ms	_{p=0.932 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,808ms (± 0.47%)}	_{2,812ms (± 1.01%)}	_~	_2,779ms	_2,850ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{4,450ms (± 1.92%)}	_{4,503ms (± 2.65%)}	_~	_4,382ms	_4,620ms	_{p=1.000 n=6}
_{Req 3 - references}	_{395ms (± 6.01%)}	_{379ms (± 0.59%)}	_~	_375ms	_381ms	_{p=0.173 n=6}
_{Req 4 - navto}	_{293ms (± 1.71%)}	_{293ms (± 1.10%)}	_~	_288ms	_297ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 9.19%)}	_{92ms (±11.68%)}	_~	_82ms	_102ms	_{p=0.746 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,648ms (± 0.32%)}	_{3,645ms (± 0.66%)}	_~	_3,609ms	_3,671ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,845ms (± 1.25%)}	_{1,832ms (± 1.35%)}	_~	_1,803ms	_1,871ms	_{p=0.298 n=6}
_{Req 3 - references}	_{129ms (± 2.79%)}	_{128ms (± 2.90%)}	_~	_124ms	_134ms	_{p=0.806 n=6}
_{Req 4 - navto}	_{373ms (± 1.02%)}	_{377ms (± 2.22%)}	_~	_372ms	_394ms	_{p=0.683 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{449ms (± 2.91%)}	_{456ms (± 1.86%)}	_~	_448ms	_472ms	_{p=0.297 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₈₇	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52387

_Metric	_main	₅₂₃₈₇	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{143.18ms (± 0.23%)}	_{142.38ms (± 0.20%)}	_{-0.80ms (- 0.56%)}	_141.67ms	_147.94ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.79ms (± 0.17%)}	_{226.82ms (± 0.18%)}	_{-0.97ms (- 0.43%)}	_225.84ms	_233.97ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{229.50ms (± 0.17%)}	_{228.52ms (± 0.15%)}	_{-0.99ms (- 0.43%)}	_227.66ms	_233.43ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{210.24ms (± 0.20%)}	_{209.38ms (± 0.21%)}	_{-0.86ms (- 0.41%)}	_208.55ms	_220.47ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₈₇	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-01T07:56:12Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52387/merge:

Everything looks good!

…-not-callable

Andarist · 2023-03-01T12:38:28Z

I would merge main since this predates the other function PRs but otherwise LGTM given we check the usual suspects.

Synced this with main 👍

Fixed an issue with top function type being callable with no arguments

0f8d091

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 24, 2023

sandersn assigned jakebailey and DanielRosenwasser Feb 1, 2023

sandersn requested review from DanielRosenwasser and jakebailey February 1, 2023 23:18

sandersn unassigned DanielRosenwasser Feb 1, 2023

jakebailey mentioned this pull request Feb 6, 2023

Improvements to strictSubtypeRelation and getNarrowedType #52282

Merged

sandersn requested a review from ahejlsberg February 6, 2023 23:59

Merge remote-tracking branch 'origin/main' into fix/top-function-type…

180ac64

…-not-callable

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 1, 2023

jakebailey approved these changes Mar 1, 2023

View reviewed changes

jakebailey merged commit 02885b1 into microsoft:main Mar 1, 2023

Andarist deleted the fix/top-function-type-not-callable branch March 1, 2023 17:40

Andarist mentioned this pull request Mar 3, 2023

Possible regression in overloads with optional this types in callbacks #53080

Closed

Andarist mentioned this pull request Jun 6, 2023

(...args: never) => void signature throws an error in TS 5.1 #54543

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Andarist commented Jan 24, 2023

Uh oh!

Andarist commented Jan 24, 2023

Uh oh!

fatcerberus commented Jan 28, 2023

Uh oh!

Andarist commented Jan 28, 2023

Uh oh!

jakebailey commented Jan 30, 2023

Uh oh!

sandersn commented Feb 1, 2023

Uh oh!

jakebailey commented Feb 1, 2023

Uh oh!

jakebailey commented Mar 1, 2023

Uh oh!

typescript-bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 1, 2023

Uh oh!

typescript-bot commented Mar 1, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Mar 1, 2023

Uh oh!

Andarist commented Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

typescript-bot commented Mar 1, 2023 •

edited

Loading

typescript-bot commented Mar 1, 2023 •

edited

Loading

typescript-bot commented Mar 1, 2023 •

edited

Loading

typescript-bot commented Mar 1, 2023 •

edited

Loading

typescript-bot commented Mar 1, 2023 •

edited

Loading