Add support for class static block#43092
Conversation
…ing except classes. Changes objects literal checking to not bail on first private name found in object literal.
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Private methods inside class expressions should not error. Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
…y assignment Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
…static-fields-methods-and-accessors
…lds-methods-and-accessors' into es-private-methods-and-accessors
…lds-methods-and-accessors' into es-private-methods-and-accessors
…/bloomberg/TypeScript into es-private-methods-and-accessors
… and modified the existing helpers for get and set fields to do the same job.
…-accessors-simplify-emit Es private methods and accessors simplify emit
|
Still confused with the boundary. |
|
I'm still reviewing #42458, and we've been discussing the fact that class C {
static #x;
static {
this.#x; // ok
this.#y; // error, #y not yet initialized
}
static #y;
static {
this.#x; // ok
this.#y; // ok
}
}Either way, I'll still be happy to review when you think this is ready. |
|
Okay, thanks a lot. BTW, there's another PR to allow this in static context. Actually, I'm confused with the function boundary in the specification(as i said in class static block repo). |
|
This one.( Sorry I'm on mobile phone ) |
|
I addressed your comment in that issue. The TL;DR is this:
|
|
I think I'd better to work based #42458. Even It's not been merged. |
|
Close for #43308. |
Fixes #43012