feat(25770): Bad error message for type used as index / add Quick Fix#40226
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Sep 8, 2020
Merged
feat(25770): Bad error message for type used as index / add Quick Fix#40226sandersn merged 1 commit intomicrosoft:masterfrom
sandersn merged 1 commit intomicrosoft:masterfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
sandersn
approved these changes
Sep 8, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One suggestion for future work, but I think it's in a good state to merge.
| container: cast(propertySignature.parent, isTypeLiteralNode), | ||
| typeNode: propertySignature.type, | ||
| constraint: propertyName, | ||
| name: propertyName === "K" ? "P" : "K", |
Member
There was a problem hiding this comment.
This is good enough for a codefix, but I think there are better ways to create a non-conflicting name in the transformer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25770 (comment)