fix(39373): const {} = require import causes Debug Failure

[a-tarasyuk]

Fixes #39373

[DanielRosenwasser]

Generally we use getNameOfDeclaration or something like that to avoid duplicating the diagnostic. It'll fill it in with something like (anonymous) or (default).

[a-tarasyuk]

@DanielRosenwasser Thanks for the feedback 👍. Actually, getHeritageClauseVisibilityError uses it

TypeScript/src/compiler/transformers/declarations/diagnostics.ts

Line 464 in 1702238

typeName: getNameOfDeclaration(node.parent.parent as Declaration)

and it returns undefined for the case

export default class extends Foo {}

Based on the type definition, a name can be undefined, however, that case was not handled in getHeritageClauseVisibilityError.

TypeScript/src/compiler/types.ts

Lines 2780 to 2781 in 1702238

	/** May be undefined in `export default class { ... }`. */
	readonly name?: Identifier;

For that reason, TS crashes because it uses diagnostic messages with two arguments, however, receive only one.

TypeScript/src/compiler/transformers/declarations.ts

Lines 141 to 144 in 1702238

	context.addDiagnostic(createDiagnosticForNode(symbolAccessibilityResult.errorNode || errorInfo.errorNode,
	errorInfo.diagnosticMessage,
	symbolAccessibilityResult.errorSymbolName,
	symbolAccessibilityResult.errorModuleName));

Do you propose to replace the missed name by creating Identifier with the(anonymous) name instead of using a new diagnostic message? I think we can do it, just need to create a new Identifier and change the logic to getting text because a new Identifier will not be present in the source file.

TypeScript/src/compiler/transformers/declarations.ts

Lines 134 to 136 in 1702238

	context.addDiagnostic(createDiagnosticForNode(symbolAccessibilityResult.errorNode || errorInfo.errorNode,
	errorInfo.diagnosticMessage,
	getTextOfNode(errorInfo.typeName),

[DanielRosenwasser]

Actually I think it's fine, especially since functions have the same diagnostic.

[DanielRosenwasser]

I actually realized that the test might need to be changed to use at least one .js file because of #39617...