fix(helpers): Use hasOwnProperty.call#37013
Closed
ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
Closed
fix(helpers): Use hasOwnProperty.call#37013ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
hasOwnProperty.call#37013ExE-Boss wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
@ExE-Boss can you update this PR? The helpers have moved to src/compiler/factory/emitHelpers.ts and the baselines need to be updated. |
Contributor
|
@ExE-Boss: If its ok with you, I'm going to try to resolve the conflicts in this PR so that I can merge it. If I'm unable to modify this PR directly, I'll probably have to create a new PR with the changes and close this one. |
Contributor
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the following code:
exports.hasOwnProperty(…)overrideresults in an error at runtime when transpiled to non‑ESM, because
exports.hasOwnProperty(…)is called with only a single non‑object argument.This also won't work in case
exportshas its prototype set tonullTSLib PR: microsoft/tslib#92
Fixes #37016
Fixes #3197