Merged
Conversation
weswigham
approved these changes
Mar 7, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
I am willing to believe that this is currently the case, even though it probably wasn't always so 😛
Member
DanielRosenwasser
left a comment
There was a problem hiding this comment.
Maybe the appropriate change is to keep FunctionLike and brand the constituents instead?
mhegazy
approved these changes
Mar 7, 2018
Author
|
Summary of offline discussion with @DanielRosenwasser: We don't need a brand type because |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionLikeandSignatureDeclarationwind up being identical types once all sub-unions are flattened. You can test this out with:My suggested fix would be to just use
SignatureDeclarationeverywhere.(Ref: #16988)