Conversation
ghost
requested review from
ghost
changed the title
mhegazy
reviewed
Mar 2, 2018
| ==== tests/cases/conformance/es6/yieldExpressions/generatorTypeCheck48.ts (1 errors) ==== | ||
| function* g() { | ||
| ~ | ||
| !!! error TS7025: Generator implicitly has type 'IterableIterator<any>' because it does not yield any values. Consider supplying a return type. |
Contributor
There was a problem hiding this comment.
this was the correct error. without noImplicitAny, it should be an implicit any and not undefined.
ghost
mentioned this pull request
sandersn
approved these changes
Mar 8, 2018
|
|
||
| function getYieldedTypeOfYieldExpression(node: YieldExpression, isAsync: boolean, checkMode?: CheckMode): Type { | ||
| const errorNode = node.expression || node; | ||
| const expressionType = node.expression ? checkExpressionCached(node.expression, checkMode) : undefinedWideningType; |
Member
There was a problem hiding this comment.
I appreciate the refactoring that is part of this PR -- it make the code much easier to read. But I want to point out that this is the only line needed to fix the bug. The bug would get fixed a lot faster if we could just review a one-line fix and look at the refactor separately.
ghost
mentioned this pull request
weswigham
approved these changes
Mar 8, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22290
Previously we would skip over
yield;with no argument; now we will treat it as yieldingundefined.