Auto import provides multiple instances of the same package in monorepo

[aminpaks]

Issue Type: Bug

1. Have a monorepo that includes multiple versions of same @type package
2. Use auto import

Here is a repository to repo the issue.

Here is a animated gif to show the issue of having multiple imports for the same package by path:

VS Code version: Code 1.56.1 (e713fe9b05fc24facbec8f34fb1017133858842b, 2021-05-06T10:08:24.325Z)
OS version: Darwin x64 20.4.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)
GPU Status	2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	32.00GB (0.27GB free)
Process Argv	--crash-reporter-id 0022c47a-4f46-441d-a819-669ad7e02cc7
Screen Reader	no
VM	0%

Extensions (30)

Extension	Author (truncated)	Version
vscode-nginx-conf	ahm	0.1.3
color-info	bie	0.6.0
tailwindshades	bou	0.0.5
vscode-tailwindcss	bra	0.6.3
gitignore	cod	0.6.0
vscode-eslint	dba	2.1.20
gitlens	eam	11.4.1
EditorConfig	Edi	0.16.4
prettier-vscode	esb	6.4.0
go	gol	0.24.2
vscode-graphql	Gra	0.3.16
vscode-env	Iro	0.1.0
search-node-modules	jas	1.3.0
vscode-styled-components	jpo	1.5.2
vscode-twined-components	low	0.0.4
change-string-case	max	1.1.2
vscode-json5	mrm	1.0.0
vscode-docker	ms-	1.12.1
python	ms-	2021.5.829140558
vscode-pylance	ms-	2021.5.1
jupyter	ms-	2021.6.832593372
js-debug-nightly	ms-	2021.5.1017
vsliveshare	ms-	1.0.4272
fix-json	oli	0.1.2
convert-css-in-js	pau	1.1.3
nginx-formatter	ray	0.0.13
vscode-commons	red	0.0.6
vscode-xml	red	0.16.0
bash-beautify	sha	0.1.1
code-spell-checker	str	1.10.2

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt678:30270856
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30294714
vscoreces:30290705
pythondataviewer:30285071
vscus158:30286553
bridgeflightcf:30299255

[andrewbranch]

I think this has been fixed—@aminpaks?

[aminpaks]

I think this has been fixed—@aminpaks?

No, what version has it fixed?

[aminpaks]

@andrewbranch I can't reproduce the issue in my own repo anymore tho it's happening in a different manner now in my companies repo. I'm trying to narrow down the issue we might wanna open another issue.

I'll let you decide if this can be closed as fixed or not. Thanks for fixing it!

[andrewbranch]

I was able to repro it yesterday in the example you provided. I thought the symptom was just like something else I fixed in the last few months, but I guess it’s something else.

[andrewbranch]

So, I have a fix for this, but this does indicate that two copies of @types/react with different versions are in your program, which is generally asking for a bad time and better to fix in your project structure. Can you not sync the version of @types/react required by different things in your monorepo so you only have one copy?

[aminpaks]

Great to hear there is fix for this, I think it's reasonable to ask the maintainer to have only one version of @types/react in the monorepo.