Repository navigation
Preserve the final batch in balanced resumable sampling - #192
Open
Afloat (Afloat16) wants to merge 1 commit into
Open
Afloat (Afloat16) wants to merge 1 commit into
Afloat (Afloat16) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BalancedResumableSampleronly visits complete global batches. After the parent sampler has already padded or truncated for distributed divisibility, a final partial batch is silently discarded; small datasets can yield no indices even thoughlen(sampler)is positive.Visit the final distributed batch as well. Its size remains divisible by world size, so the existing equal-size load balancing preserves equal per-rank sample counts.
drop_lastcontinues to control the distributed remainder through the parent sampler.Regression tests check sample conservation and reported cardinality across ranks, small datasets, distributed
drop_last, and resume offsets through the tail. Runpython -m unittest discover -s tests -p test_trellis2_balanced_tail.py -v.Validation: native CPU regression tests pass on this branch; the same tests fail against the pinned original source. Validation run.
Exact-head validation: all 3 native CPU regression tests pass at
167651ac9c01c43b3ded45f0e689a074a2434df0. Restoring the original production files at75fbf0183001ed9876c8dbb35de6b68552ee08bdmakes the same complete suite fail on the original behavior, with no skipped tests or import failures. Candidate and original-source logs.