Repository navigation
Slai Agent Runtime:Preserve unavailable workflow-only Windows unit-test contracts - #85
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Slai Agent Runtime replays Windows benchmark rows in their published task images to distinguish candidate-specific outcomes from a published grading contract that cannot observe the requested change.
During the formal Windows replay of
podman-desktop__podman-desktop-13439, both patches applied successfully:test_patchchanges only.github/workflows/e2e-main.yaml;.github/workflows/pr-check.yaml.The published Windows command is only:
It ran the repository's Vitest workspace (4,593 reported tests; three unrelated UI assertion failures), but it neither reads nor executes either
.github/workflows/*.yamlfile. Thus, regardless of whether those unrelated unit failures are green or red, the command cannot establish whether the Windows ARM workflow-matrix change requested by the row is correct.This PR protects that existing evaluation gap. It does not mark the Podman candidate solved, parse YAML to award a pass, replace the published command, or modify benchmark data.
Change
Return an unavailable result only when all of the following are true:
.github/workflows/*.ymlor.yamlfiles;pnpm test:unit; andactionlint,yamllint,act, orgh workflow). Merely reading a workflow file is not semantic validation.The preserved result is:
{ "resolved": null, "grading_status": "unavailable", "failure_class": "windows_github_actions_workflow_contract_unobservable_by_published_unit_command" }Replay evidence
The guard was replayed against the unmodified published manifest row and the exact preserved candidate patch:
The prior formal artifacts remain separate evidence: the evaluator applied both patches, then the published unit command returned nonzero due to unrelated renderer/UI assertions. Those assertions do not inspect the workflow files.
Recommended dataset repair for
podman-desktop__podman-desktop-13439This evaluator guard only prevents a false candidate failure; it cannot make the row scoreable. To make the row scoreable, the dataset needs an official regression check that actually reads the workflow definitions and asserts the intended matrix/runner semantics.
For example, add a small deterministic Node/TypeScript or PowerShell validation script through the official test patch, then append that script to the published
test_cmds. The check should parse the two workflow files and assert that the update-E2E jobs in both:include both
windows-2025andwindows-11-arm, and that the job runner is driven by the corresponding matrix where applicable. A syntax-only linter is insufficient: the regression must assert these matrix values.After such a dataset/command repair, candidates can be formally rerun and judged on the intended behavior.
Validation
The tests cover the positive workflow-only/unit-only condition; Linux, source-file, non-unit-command, and explicit workflow-validation paths, plus the read-only workflow-path guard; and persistence of
resolved: nullwithout using unrelated unit-test outcomes to score the candidate.