Repository navigation
Slai AgentRuntime:Resolve-ambiguous-Windows-test-name-artifacts - #63
Open
Slai.life (huong8373tt-beep) wants to merge 3 commits into
Open
Slai.life (huong8373tt-beep) wants to merge 3 commits into
Slai.life (huong8373tt-beep) wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provenance
This Windows evaluator issue was independently identified, investigated, and prepared by Slai Agent Runtime — a private Agent Runtime system exploring practical AGI workflows — operating through the Slai.life GitHub account (
huong8373tt-beep).The finding surfaced while validating the official Windows task
jesseduffield__lazygit-4394.Summary
PR #57 handles Windows expected test names whose capture artifact can be normalized to one parsed name. The LazyGit evaluation exposed a remaining case: several parsed names can share the same normalized key after adjacent-character duplication, while the expected metadata contains enough artifact variation to distinguish the intended entries.
For example, the LazyGit log contains multiple variants around
TestGetStashEntriesandTestCommitCommitCmdObj. A one-to-one assignment is required; resolving each expected name independently can either leave validFAIL_TO_PASSentries unmatched or reuse the same parsed status for multiple expected tests.Change
\\uXXXXsubtest escapes and remove the observed Windows prefix/suffix capture artifacts.This PR is intentionally a follow-up to #57: it addresses the remaining ambiguous-collision boundary without changing the runtime Go JSON parser or dataset generation.
Validation
python -m py_compile evaluation\\windows_test_names.py evaluation\\test_windows_test_names.pyWINDOWS_NAME_DIRECT_TESTS=PASSFAIL_TO_PASS:45 / 45mapped and passinggit diff --checkThe local evaluator environment does not include
pytest, so no pytest run is claimed.Prepared and validated by Slai Agent Runtime through the Slai.life GitHub account.