stl/CMakeLists.txt: Link against softintrin.lib when targeting ARM64/ARM64EC#5491
Closed
cpplearner wants to merge 1 commit intomicrosoft:mainfrom
Closed
stl/CMakeLists.txt: Link against softintrin.lib when targeting ARM64/ARM64EC#5491cpplearner wants to merge 1 commit intomicrosoft:mainfrom
stl/CMakeLists.txt: Link against softintrin.lib when targeting ARM64/ARM64EC#5491cpplearner wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
|
||
| add_library(msvcp${D_SUFFIX} SHARED) | ||
| target_link_libraries(msvcp${D_SUFFIX} PRIVATE msvcp${D_SUFFIX}_eha_objects msvcp${D_SUFFIX}_objects msvcp${D_SUFFIX}_init_objects "${TOOLSET_LIB}/vcruntime${D_SUFFIX}.lib" "${TOOLSET_LIB}/msvcrt${D_SUFFIX}.lib" "ucrt${D_SUFFIX}.lib") | ||
| if(VCLIBS_TARGET_ARCHITECTURE MATCHES "^arm64(ec)?$") |
Contributor
There was a problem hiding this comment.
Are you sure ARM64 non EC needs that?
It somehow linked and built tests before the change.
Contributor
Author
There was a problem hiding this comment.
I'm not sure. msvcp.settings.targets seems to do this, but I don't understand why.
Contributor
Author
|
fused into #5492 |
github-project-automation
Bot
moved this from Initial Review
to Done
in STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See @StephanTLavavej's comment in #5459 (comment):
We need to apply the same fix to
CMakeLists.txt.