Compare the _W_decimal_point of the localeconv, not the decimal_point of said localeconv

[LumioseSil]

Since s is a pointer to a wchar_t, it makes more sense to use the wchar_t field of the localeconv struct returned. decimal_point and _W_decimal_point are identical for all supported locales, so this is not a behavioral change.

Additional cleanups, keeping narrow xstoxflt.cpp and wide xwstoxfl.cpp in sync:

• Move the definition of int word; down; it doesn't need to be initialized because it's always assigned.
• Upgrade digits and vals to constexpr. Consistently comment them at the end. Consistently use a string literal to initialize digits, which provides a null terminator.
• Narrow xstoxflt.cpp should use a while-loop, as wide xwstoxfl.cpp was already doing.
  • This is doing something complicated and less structured, so the while-loop is more appropriate.
• if (seen) { ... } followed by if (!seen) { ... } can simply use else, as we don't modify seen here.

[StephanTLavavej]

Thanks - I've pushed the following changes to resolve code review feedback, also getting xstoxflt.cpp and xwstoxfl.cpp synced up.

• Move the definition of int word; down.
• Also upgrade vals to constexpr.
• Style: Attach } else {.
• xstoxflt.cpp: Mirror } else { change.
• xstoxflt.cpp: Mirror int word; change.
• xstoxflt.cpp: Mirror constexpr change.
• xstoxflt.cpp: (pre-existing) Mirror while-loop.
  • This is doing something complicated and less structured, so the while-loop is more appropriate.
• (pre-existing) Harmonize narrow/wide definitions of digits/vals.
  • xstoxflt.cpp: Add comment to digits. Move vals comment to end.
  • xwstoxfl.cpp: Use a wide string literal to initialize digits, which provides the null terminator. Move comments to end.

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

Thanks for this code cleanup! 😸 😸 😸 😸