Repository navigation
MAINT: Add Copilot cleanup phase context - #3351
Merged
Roman Lutz (romanlutz) merged 1 commit intoOct 20, 2026
Merged
Roman Lutz (romanlutz) merged 1 commit into
Roman Lutz (romanlutz) merged 1 commit into
Conversation
7 of 25 tasks
Roman Lutz (romanlutz)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the remaining focused P311-08 Copilot cleanup-phase investigation from #3166.
GitHubCopilotTarget._cleanup_owned_resources_asyncnow adds safe static phase-name notes when failures arise during session release, active-client stop, or failed-startup-client stop. The change preserves the original exception objects, types, tracebacks, existing notes, release ordering, retry ownership, cancellation behavior, and established single-error /BaseExceptionGroupshape.The notes contain only static lifecycle phase names; they do not include conversation/session identifiers, working directories, tokens, prompts, seed content, or other runtime content.
Tests and Documentation
uv run --frozen --no-sync pytest -q --basetemp=D:\oss_contrib\pyrit-p311-08\.pytest-tmp-copilot-cleanup tests/unit/prompt_target/target/test_github_copilot_target.py— 98 passed.uv run --frozen --no-sync pre-commit run --files pyrit/prompt_target/github_copilot_target.py tests/unit/prompt_target/target/test_github_copilot_target.py— passed, including Ruff and ty.git diff --check— passed.No documentation changes were needed.
Slai Agent Runtime assisted with investigation, implementation, and tests. The account owner reviewed and authorized this contribution.