Repository navigation
FIX: Isolate Copilot model identity test from startup I/O delays - #3327
Merged
Roman Lutz (romanlutz) merged 1 commit intoOct 19, 2026
Merged
Roman Lutz (romanlutz) merged 1 commit into
Roman Lutz (romanlutz) merged 1 commit into
Conversation
Reuse mocked startup I/O and the shared test watchdog so model identity assertions do not depend on database or thread scheduling latency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 30773f5a-6e15-49e6-bf6b-a7aec1305f75
jbolor21
approved these changes
Oct 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pre-existing model identity test timed out waiting for mocked Copilot startup in the macOS Python 3.12 CI job for #3281. Before reaching that mock, the test reads memory history and dispatches the mocked SDK constructor to a worker thread. The exact CI delay is unproven, and the isolated test passes locally.
Reuse
mock_copilot_startup_ioto remove those unrelated I/O and scheduling dependencies, and useTEST_WATCHDOG_SECONDSfor startup entry instead of a two-second latency limit. All model identity freeze assertions and cleanup behavior remain unchanged. This is a test-only fix, separate from #3281, with no production changes.Tests and Documentation
Validated on Windows with Python 3.14.4:
uv run --frozen --extra github-copilot python -m pytest tests\unit\prompt_target\target\test_github_copilot_target.py tests\unit\backend\test_analytics_lifecycle.py -q: passed, 109 tests.uv run --frozen --extra github-copilot python -m ruff check tests\unit\prompt_target\target\test_github_copilot_target.py: passed.uv run --frozen --extra github-copilot python -m ruff format --check tests\unit\prompt_target\target\test_github_copilot_target.py: passed.git diff --check: passed.The macOS Python 3.12 job was not rerun. Documentation and JupyText are not applicable to this test-only change.