Component governance: generate requirements.txt file#12
Merged
romanlutz merged 1 commit intoJan 17, 2024
Merged
Conversation
rdheekonda
approved these changes
Jan 17, 2024
romanlutz
deleted the
romanlutz/component_governance_generate_requirements
branch
rlundeen2
added a commit
to rlundeen2/PyRIT
that referenced
this pull request
May 28, 2026
- atomic_attack.py: use 'unknown' instead of '?' in the executor max_concurrency log fallback (review microsoft#7). - scenario.py: extract the post-gather error-collection loop into a new _collect_errors_from_outcomes helper for readability (review microsoft#10). - scenario.py: rewrite the comment block above the parallel-execution branch per Justin's suggestion to name the AttackExecutor-level Semaphore and the parameter-build + attack-execution units of work (review microsoft#11). - test_attack_executor.py: add four regression tests for AttackExecutor._get_semaphore covering lazy construction, in-loop reuse, and rebuild across asyncio.run() invocations (review microsoft#12). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Component governance didn't manage to detect our dependencies since we're using poetry (which is in beta right now). To remedy this, I generated the requirements.txt file before running component detection. This appears to work in a little test I conducted ahead of this PR. Once poetry is supported properly we can remove this workaround, but we don't have a concrete target date at this point.
Tests
Documentation