Skip to content

Added source, withinPath and notWithinPath expressions#960

Merged
ArmaanMcleod merged 4 commits into
microsoft:mainfrom
ArmaanMcleod:source-expression
Feb 6, 2022
Merged

Added source, withinPath and notWithinPath expressions#960
ArmaanMcleod merged 4 commits into
microsoft:mainfrom
ArmaanMcleod:source-expression

Conversation

@ArmaanMcleod

@ArmaanMcleod ArmaanMcleod commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #933.

Added the following expressions:

  • source
  • withinPath
  • notWithinPath

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod
ArmaanMcleod requested a review from a team as a code owner February 6, 2022 04:19

@BernieWhite BernieWhite left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Rocking it! All good to merge. Nice work.

@ArmaanMcleod

Copy link
Copy Markdown
Contributor Author

@ArmaanMcleod Rocking it! All good to merge. Nice work.

Thanks @BernieWhite. Appreciate all the help from you along the way 🙂.

@ArmaanMcleod
ArmaanMcleod merged commit b05d4f3 into microsoft:main Feb 6, 2022
@ArmaanMcleod
ArmaanMcleod deleted the source-expression branch February 6, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a source expression property

2 participants