Skip to content

Added expression support for type based assertions#942

Merged
ArmaanMcleod merged 4 commits into
microsoft:mainfrom
ArmaanMcleod:expression-type-based-assertions
Jan 30, 2022
Merged

Added expression support for type based assertions#942
ArmaanMcleod merged 4 commits into
microsoft:mainfrom
ArmaanMcleod:expression-type-based-assertions

Conversation

@ArmaanMcleod

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #908

Added the following expressions:

  • IsArray
  • IsBoolean
  • IsDateTime
  • IsInteger
  • IsNumeric

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod
ArmaanMcleod requested a review from a team as a code owner January 30, 2022 02:36

@BernieWhite BernieWhite left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod A few minor suggestions but otherwise all good to merge. Nice work!

Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Comment thread tests/PSRule.Tests/SelectorTests.cs Outdated
Co-authored-by: Bernie White <bewhite@microsoft.com>
@ArmaanMcleod

Copy link
Copy Markdown
Contributor Author

@ArmaanMcleod A few minor suggestions but otherwise all good to merge. Nice work!

Thanks @BernieWhite 🎉. Have applied your suggestions, thanks for picking that up 🙂.

@ArmaanMcleod
ArmaanMcleod merged commit d6d90a1 into microsoft:main Jan 30, 2022
@ArmaanMcleod
ArmaanMcleod deleted the expression-type-based-assertions branch January 30, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add expression support for type based assertions

2 participants