This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Repository navigation
Update docstring on read_schema. - #25
Merged
Monte Hoover (montebhoover) merged 4 commits intoOct 25, 2018
Merged
Monte Hoover (montebhoover) merged 4 commits into
Monte Hoover (montebhoover) merged 4 commits into
Conversation
Monte Hoover (montebhoover)
requested review from
Gal Oshri (GalOshri),
Gani Nazirov (ganik) and
Yiwen Zhu (zyw400)
October 25, 2018 05:49
Gani Nazirov (ganik)
approved these changes
Oct 25, 2018
Contributor
Author
|
Fixes #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_schema takes a number **kwargs, and some were missing from the docstring. On the docs site we use some of them in examples but because they are missing from the docstring they are absent from the official API reference.
Fixes #11