Fixes AD0001 in UNT0038#472
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes AD0001 thrown by UNT0038 (CacheYieldInstructionAnalyzer) when a yielded object creation has more than one literal argument. The original code used SingleOrDefault which throws when multiple matching elements exist; the fix restricts analysis to object creations with exactly one argument that is a literal.
Changes:
- Replace
SingleOrDefaultlookup with explicit "single argument that is a literal" check. - Add a regression test for yielded constructions with multiple literal arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Unity.Analyzers/CacheYieldInstructionAnalyzer.cs | Replaces unsafe SingleOrDefault predicate with a Count==1 + literal check. |
| src/Microsoft.Unity.Analyzers.Tests/CacheYieldInstructionAnalyzerTests.cs | Adds regression test reproducing the AD0001 scenario from issue #471. |
jbevain
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
Checklist
Short description of what this resolves:
Replaced unsafe construct with a proper check.