Add the ordered-view incremental render engine that projects the grid, histogram, and status-bar presentation from a columnar store - #672
Merged
Conversation
…, histogram, and status-bar presentation from a columnar store
Joseph Schick (jschick04)
force-pushed
the
jschick/ordered-view-1-engine
branch
from
August 12, 2026 00:36
8d7356d to
e0ae742
Compare
Joseph Schick (jschick04)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 60 out of 60 changed files in this pull request and generated no new comments.
Suppressed comments (3)
src/EventLogExpert.Runtime/LogTable/FilteredPresenceInvalidatedAction.cs:9
- UpdateTableAction was removed/replaced by FilteredPresenceInvalidatedAction here, but there are still usages of UpdateTableAction and DisplayReadyAction in EventLog/FilteringEffects.cs, EventLog/LogReloadEffects.cs, and UI subscriptions. This PR will not build until those call sites are migrated or compatibility actions are reintroduced.
src/EventLogExpert.Runtime/LogTable/IActiveEventLogSource.cs:12 - This change removes the previous AppendTableEventsAction type (this file now defines IActiveEventLogSource), but other parts of the solution still reference AppendTableEventsAction / AppendTableEventsBatchAction (e.g., UI LogTablePane.razor.cs and runtime PartialLoadCoordinator/LogReloadEffects). In this PR as-is, those references will fail to compile unless the action types are retained as shims or all call sites are updated in the same PR.
src/EventLogExpert.Runtime/LogTable/OrderedView/OrderedColumnView.cs:21 - EventColumnView (and DisplayViewBuilder) were removed/renamed as part of the ordered-view engine, but there are still references to EventColumnView and DisplayViewBuilder in EventLog/FilteringEffects.cs, PartialLoadCoordinator.cs, and LogReloadEffects.cs. Without either shims or a same-PR migration of those call sites, the solution will not compile.
…rs in place of Fluxor selectors
…rformance docs for the ordered-view migration
…r modal's close request
…rdless of process uptime
…ners by widening the hello handshake window
Joseph Schick (jschick04)
marked this pull request as ready for review
August 12, 2026 12:42
…nd organize AddEventLogRuntime into labeled sections
Nick Tilton (NikTilton)
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 1 of 5, base
main.Introduces the ordered-view incremental render engine in the LogTable layer. A columnar event store and ordered/combined column views project an immutable presentation snapshot; the grid, histogram, and status bar render from that snapshot instead of recomputing state on every render.
In this slice: the engine sources under
src/EventLogExpert.Runtime/LogTable/. Its unit tests follow in PR 2; consumers are rewired in PRs 3 to 5.Split by area into five stacked PRs to keep each within review limits. Review in order: 1 engine core (this), 2 engine tests, 3 runtime, 4 UI, 5 support.