Start working on the release migration#1721
Draft
ChFlick wants to merge 2 commits into
Draft
Conversation
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Pull request overview
This PR scaffolds an in-progress migration to ship ama-logs as an independent AKS managed-cluster extension (Helm chart in MCR) with its own central-artifacts Ev2 Managed SDP rollout, decoupling the logs agent release cadence from the AKS release train.
Changes:
- Adds a new parallel Helm chart (
azuremonitor-containers-extension) intended for AKS managed-cluster extension delivery ofama-logs. - Introduces an Ev2 Managed SDP rollout pipeline for AKS managed clusters and a gated build job to package/push the extension chart to ACR/MCR.
- Adds migration/release documentation and a local PowerShell helper for templating/linting/installing the new chart outside the build pipeline.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Documentation/AgentRelease/extension-release.md | WIP doc describing the new AKS extension-based release model and flow. |
| charts/azuremonitor-containers-extension/Chart-template.yaml | Chart metadata template stamped via envsubst during packaging. |
| charts/azuremonitor-containers-extension/values-template.yaml | Values template for packaging-time stamping + extension-platform injected values. |
| charts/azuremonitor-containers-extension/.helmignore | Helm packaging ignore rules for the new chart. |
| charts/azuremonitor-containers-extension/.gitignore | Ignores rendered Chart.yaml / values.yaml and packaged tgz artifacts. |
| charts/azuremonitor-containers-extension/EXTENSION-MIGRATION.md | Migration plan + remaining work checklist for extension readiness. |
| charts/azuremonitor-containers-extension/local_testing_aks.ps1 | Local render/lint/template/install helper for the extension chart. |
| charts/azuremonitor-containers-extension/templates/_helpers.tpl | Standard Helm helper templates for naming/labels. |
| charts/azuremonitor-containers-extension/templates/ama-logs-secret.yaml | Secret template for workspace credentials + proxy material. |
| charts/azuremonitor-containers-extension/templates/ama-logs-rs-configmap.yaml | ReplicaSet Fluentd config ConfigMap (mirrors existing chart behavior). |
| charts/azuremonitor-containers-extension/templates/ama-logs-rbac.yaml | ServiceAccount + ClusterRole/Binding for the agent. |
| charts/azuremonitor-containers-extension/templates/ama-logs-priorityclass.yaml | PriorityClass used by the agent DaemonSets/Deployment. |
| charts/azuremonitor-containers-extension/templates/ama-logs-openshift-scc.yaml | OpenShift SCC template (carried over from base chart). |
| charts/azuremonitor-containers-extension/templates/ama-logs-deployment.yaml | ama-logs-rs Deployment template. |
| charts/azuremonitor-containers-extension/templates/ama-logs-daemonset.yaml | Linux DaemonSet template (incl. optional token adapter container). |
| charts/azuremonitor-containers-extension/templates/ama-logs-daemonset-windows.yaml | Windows DaemonSet template. |
| charts/azuremonitor-containers-extension/templates/ama-logs-arc-k8s-crd.yaml | Arc extension identity/identity request CRDs (carried over from base chart). |
| .pipelines/azure-pipeline-aks-extension-managed-ev2-sdp.yml | New central-artifacts Ev2 Managed SDP rollout pipeline for AKS managed clusters. |
| .pipelines/azure_pipeline_mergedbranches.yaml | Adds a gated job to render/package/push the extension chart as an OCI artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
+36
| ## Identity is injected by the AKS extension framework: the managed-addon token | ||
| ## adapter sidecar yaml is supplied here by the platform. | ||
| ## TODO(P0): confirm the exact token-adapter values the partner team injects. | ||
| Identity: | ||
| AADMsiTokenAdapterLinuxYaml: "" | ||
| AADMsiTokenAdapterWindowsYaml: "" |
fe1d53b to
d553663
Compare
d553663 to
8feeb7a
Compare
- Chart-template.yaml: add type:application, quote appVersion - Use Azure.Identity.AADMsiTokenAdapterLinuxYaml in daemonset/deployment to match values + the aks/extension-charts branch (fixes PR review identity-key mismatch) - Remove vestigial INCLUDE_DEPENDENT_CHARTS (logs has no subchart dependency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.