Change ReturnIfFailed to ThrowIfFailed in Python\device.cpp#232
Merged
Conversation
Contributor
Author
|
A soft ping~thanks! @adtsai |
adtsai
suggested changes
May 3, 2022
| @@ -16,7 +16,7 @@ using Microsoft::WRL::ComPtr; | |||
| HRESULT IsWarpAdapter(IDXGIAdapter1* pAdapter, bool* isWarpAdapter) | |||
Contributor
There was a problem hiding this comment.
Since this no longer returns anything other than S_OK, can this function just return a bool directly? This will eliminate the need for the isWarpAdapter out param.
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for your suggestions! I updated as that, PTAL again, thanks! @adtsai
adtsai
approved these changes
May 4, 2022
Contributor
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find that device.cpp uses
ThrowIfFailedto handle errors, but I usedReturnIfFailedin my last PR. I am so sorry for that and now change it to align, please help to take a look! Thanks very much! @adtsai