Conversation
In the 10.0.19041.0 SDK, the definitions for GetThreadLocale and SetThreadLocale were moved under a #if(WINVER >= 0x0500) check, where there was no such check before. Adjust the detours build to have the same check, to avoid consuming undeclared functions
Add a simple workflow that builds x86 and x64 build architecture on push to master, or to validate pull requests before merge.
bgianfo
force-pushed
the
initial-ci-workflow
branch
from
064dd3c to
26f0bff
Compare
bgianfo
force-pushed
the
initial-ci-workflow
branch
from
b5aabe7 to
cba6344
Compare
jaykrell
reviewed
Aug 21, 2020
| HDESK (__stdcall * Real_GetThreadDesktop)(DWORD a0) | ||
| = GetThreadDesktop; | ||
|
|
||
| #if(WINVER >= 0x0500) |
Member
There was a problem hiding this comment.
Also, can declare the function yourself.
Assuming the import libs have no such filtering.
I'm not sure which is best. Versioning is an unsolved mess (except for just staying at head like some large orgs..)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple workflow that builds x86 and x64 build architectures on push to master, or to validate pull requests.
It currently builds with MSVC:
It also runs CodeQL analysis with the build, so we can get further static analysis from the CodeQL rule-sets.
In order to get the code building in on the latest Windows Kit SDK, I had restrict the use of GetThreadLocale/SetThreadlocale
under WINVER guard, as the SDK headers introduced the same check.
I've also included a commit to disable more logo banners, as that seems to be the convention in the rest of the build.