Conversation
|
I'd personally not add the implicit conversion operator, as it encourages the |
Contributor
|
That would hurt usability of all APIs that use |
|
That's why I suggested adding an analyzer instead, that would warn for such usages. |
Member
Author
|
I imagine analyzers could be a huge win for users. But also a bottomless pit of work. If folks are interested in sending PRs that add analyzers, I will try to find time to add the first one as a template for how more can be added. |
AArnott
added a commit
that referenced
this pull request
Sep 5, 2025
Fix unofficial build with SDL tools enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362