package.json is inconsistent with package-lock.json#4411
Merged
compulim merged 2 commits intomicrosoft:mainfrom Sep 12, 2022
Merged
package.json is inconsistent with package-lock.json#4411compulim merged 2 commits intomicrosoft:mainfrom
package.json is inconsistent with package-lock.json#4411compulim merged 2 commits intomicrosoft:mainfrom
Conversation
tdurnford
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
packages/support/cldr-data/package.json, by @compulim, in PR #4411Description
In #4392, we missed committing
packages/support/cldr-data/package.json. However, CI PR validation passed for unknown reason. Both our daily build and some dev boxes failed.We are also enabling
--force-localswitch in Lerna to make sure this won't get pass CI PR validation next time.Design
When running
lerna bootstrap --ci, it may regard the--ciflag for a few reasons (non-exhaustive):< 5.7.0--force-localis specified)Since we adopted
cldr-data, we are hitting point 3, thus,lernadisabled--ci.We are adding a new
--force-localswitch to make sure we use the local version ofcldr-datainstead of NPM.Specific Changes
packages/support/cldr-data/package.jsonto useglob@^8.0.3lerna.jsonand add--force-localflagCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)