Fix diagnostic-channel Console Import - #1452
Merged
Jackson Weber (JacksonWeber) merged 1 commit intoJul 29, 2025
Merged
Conversation
|
This issue is related to this error, right? ./node_modules/applicationinsights/out/src/logs/autoCollectLogs.js:16:6-73 - Error: Module not found: Error: Can't resolve '../../out/src/logs/diagnostic-channel/console.sub' in '/ng-app/node_modules/applicationinsights/out/src/logs' Please, I would need that be resolved as soon as possible since I have to compile a new version in production and this error is locking it. Thanks in advance. |
Jackson Weber (JacksonWeber)
requested review from
Jackson Weber (JacksonWeber) and
Copilot
July 29, 2025 22:19
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build-breaking path resolution issue in the AutoCollectLogs class by correcting relative paths from ../../out/src/logs/ to ../../../out/src/logs/ to properly resolve module paths in fallback require statements.
- Updates fallback require paths to prevent double "out" directory resolution
- Fixes path resolution in both enable() and dispose() methods
Jackson Weber (JacksonWeber)
approved these changes
Jul 29, 2025
Jackson Weber (JacksonWeber)
changed the title
Jackson Weber (JacksonWeber)
merged commit Jul 29, 2025
d53fc96
into
microsoft:main
16 checks passed
This was referenced Jul 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a build-breaking issue. The current code resolves to .../out/out/..., which looks like an unintentional typo. Please review.