This repository was archived by the owner on Sep 28, 2020. It is now read-only.
statics: Remove unneeded (and kinda odd) static str's#2
Merged
Conversation
kallisti5
commented
Jul 14, 2020
- These make non-static str database names ackward to use
* These make non-static str database names ackward to use
Author
|
congrats! 66Origin doesn't seem interested in maintaining Sofa, so you get my PR's ;-) Had a quick discussion in rust channels about this.. these static str's are really weird, and add a ton of un-needed complexity around non static (aka non- "databasename") values. Here's an example common error: |
Author
|
|
Sorry this took a while, but I agree that these are a bit awkward. Let me merge this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.