You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(web): lift the jsdom <30.1 Dependabot hold once vitest supports jsdom 30.1 #955
#954 holds jsdom below 30.1 in .github/dependabot.yml. Dependabot cannot report when the hold is no longer needed, so this issue tracks it.
Cause. jsdom 30.1 moved its wrapper impl from an own Symbol(impl) property to a private class field. Vitest's jsdom makeCompatBlob shim finds the impl through the first own symbol. It now finds none and throws Cannot read properties of undefined (reading '_buffer') on every URL.createObjectURL(blob) call. This failed the 5 Login — cached pre-auth banner (#833) tests in #952.
On a branch, bump vitest, @vitest/coverage-v8 and jsdom (to the newest 30.x), then run npx vitest run src/routes/Login.test.tsx from web/. All tests must pass.
Remove the jsdomignore block from .github/dependabot.yml in the same PR.
Known cost while the hold is in place: jsdom is dev-only, so the npm audit gate (--omit=dev) does not block on a jsdom advisory. A jsdom fix at 30.1 or later could also be withheld while the ignore rule is active. It has not been checked whether Dependabot applies this rule to security updates.
Activity
mforce commentedon Sep 25, 2026
Not needed: the jsdom hold (#954) was closed unmerged. Waiting for the vitest fix instead; tracked on #952.