Fix integer overflow during unfolding of the rice residual#61
Fix integer overflow during unfolding of the rice residual#61mewmew merged 1 commit intomewkiz:masterfrom
Conversation
|
This is additionally documented here: https://www.ietf.org/archive/id/draft-ietf-cellar-flac-12.html#name-rice-coding
edit: uhh, I just realize this is for encoding. For decoding it is a little different. |
|
Wonderful! Thanks @MarkKremer for the fix and @ktmf01 for the docs : ) This is truly open source at its finest! Cheers, |
|
The v1.0.9 release has now been tagged. Very happy to see that the audio samples of the IETF test cases are now correctly decoded by Cheerful regards, |
Solves #60
Fix found by looking really hard at the reference code:
https://github.com/xiph/flac/blob/8cf7e7fbb536e3968efe1e442922c514ca99f9c0/src/libFLAC/deduplication/bitreader_read_rice_signed_block.c#L91