Refactor: Remove Overlay permission from default list#14
Merged
Conversation
This commit removes the `PermissionType.OVERLAY` from the default list of permissions requested by `TriggerXPermissionComposable`. It also removes the corresponding `SYSTEM_ALERT_WINDOW` permission from the sample app's `AndroidManifest.xml`.
Key changes:
- **triggerx/src/main/java/com/meticha/triggerx/permission/TriggerXPermissionComposable.kt**:
- Removed `PermissionType.OVERLAY` from the `addAll` list in the `rememberPermissionStates` function.
- **app/src/main/AndroidManifest.xml**:
- Removed the `<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />` declaration.
- Removed the comment related to displaying an Activity over other apps/lock screen.
WalkthroughThe changes remove the SYSTEM_ALERT_WINDOW (overlay) permission from the AndroidManifest.xml and from the list of permissions managed in the permission composable. The release workflow version was also updated from 0.0.5 to 0.0.6. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This commit updates the `VERSION_NAME` environment variable in the release workflow.
Key changes:
- **.github/workflows/release.yaml**:
- Changed `VERSION_NAME` from `0.0.5` to `0.0.6`.
meticha-admin
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit