pyproject: allow building against Cython 3.1#36
Conversation
Arch Linux already builds against Cython 3.1.6 with v0.6.6, but in v0.6.7 the Cython version checked was restricted to 3.0.x while it compiles and the tests pass against 3.1.6.
WalkthroughUpdated the Cython build-system dependency version constraint from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
3-3: Add an explicit lower bound to the Cython version constraint.The constraint
Cython<=3.2lacks a lower bound, which could allow potentially incompatible older versions to be installed. While the previous constraint~=3.0.11restricted to[3.0.11, 3.1.0), the new constraint should maintain a minimum version requirement.Apply this diff to explicitly specify both lower and upper bounds:
- "Cython<=3.2", + "Cython>=3.0.11,<=3.2",Alternatively, if broader compatibility is desired:
- "Cython<=3.2", + "Cython>=3.0.11,<4.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
2-5: Cython version constraint is valid and supports the intended range.The
<=3.2constraint correctly allows Cython 3.1.x versions (3.1.6 through 3.1.0 are available on PyPI) and is forward-compatible with any future 3.2.0 release. The constraint properly rejects 3.2.1 and higher. No compatibility issues detected.
Arch Linux already builds against Cython 3.1.6 with v0.6.6, but in v0.6.7 the Cython version checked was restricted to 3.0.x while it compiles and the tests pass against 3.1.6.
Summary by CodeRabbit