Skip to content

pyproject: allow building against Cython 3.1#36

Open
jelly wants to merge 1 commit into
methane:masterfrom
jelly:bump-cython
Open

pyproject: allow building against Cython 3.1#36
jelly wants to merge 1 commit into
methane:masterfrom
jelly:bump-cython

Conversation

@jelly

@jelly jelly commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Arch Linux already builds against Cython 3.1.6 with v0.6.6, but in v0.6.7 the Cython version checked was restricted to 3.0.x while it compiles and the tests pass against 3.1.6.

Summary by CodeRabbit

  • Chores
    • Updated build system dependency version constraints to support newer compatible releases.

Arch Linux already builds against Cython 3.1.6 with v0.6.6, but in
v0.6.7 the Cython version checked was restricted to 3.0.x while it
compiles and the tests pass against 3.1.6.
@coderabbitai

coderabbitai Bot commented Nov 3, 2025

Copy link
Copy Markdown

Walkthrough

Updated the Cython build-system dependency version constraint from ~=3.0.11 to <=3.2, broadening compatibility to allow Cython versions up to 3.2.x.

Changes

Cohort / File(s) Summary
Build system dependency update
pyproject.toml
Modified Cython version constraint in build-system.requires from ~=3.0.11 to <=3.2, permitting newer minor and patch releases within the 3.x series up to 3.2

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version constraint, loosened with care,
From three-point-oh to three-point-two there,
Cython now hops through releases anew,
Building with freedom—dependencies too! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'pyproject: allow building against Cython 3.1' accurately summarizes the main change in the changeset. It clearly indicates that the modification involves the pyproject configuration file and specifically addresses enabling compatibility with Cython 3.1, which aligns with the actual change from 'Cython~=3.0.11' to 'Cython<=3.2'. The title is concise, specific, and directly reflects the primary objective of the PR.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

3-3: Add an explicit lower bound to the Cython version constraint.

The constraint Cython<=3.2 lacks a lower bound, which could allow potentially incompatible older versions to be installed. While the previous constraint ~=3.0.11 restricted to [3.0.11, 3.1.0), the new constraint should maintain a minimum version requirement.

Apply this diff to explicitly specify both lower and upper bounds:

-    "Cython<=3.2",
+    "Cython>=3.0.11,<=3.2",

Alternatively, if broader compatibility is desired:

-    "Cython<=3.2",
+    "Cython>=3.0.11,<4.0",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d64b462 and e40dbb0.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

2-5: Cython version constraint is valid and supports the intended range.

The <=3.2 constraint correctly allows Cython 3.1.x versions (3.1.6 through 3.1.0 are available on PyPI) and is forward-compatible with any future 3.2.0 release. The constraint properly rejects 3.2.1 and higher. No compatibility issues detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant