Repository navigation
Remove volatile modifier from ImmutableConciseSet.WordIterator.hasNextWord and ConciseSet.modCount fields - #14
Merged
Merged
Conversation
…tWord and ConciseSet.modCount fields
leventov
added a commit
to metamx/druid
that referenced
this pull request
Jan 25, 2017
…set#14, metamx/extendedset#15, metamx/bytebuffer-collections@9b199e3, metamx/bytebuffer-collections#38 to Druid, remove unused code from extendedset module
drcrallen
pushed a commit
to apache/druid
that referenced
this pull request
Feb 11, 2017
… (part of #3798) (#3883) * Port of metamx/extendedset#10, metamx/extendedset#13, metamx/extendedset#14, metamx/extendedset#15, metamx/bytebuffer-collections@9b199e3, metamx/bytebuffer-collections#38 to Druid, remove unused code from extendedset module * Remove ConciseSet.modCount * Replace comments with assertions in ImmutableConciseSet * Fix comments * Fix asssertions in ImmutableConciseSet * Add tests * Comment fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the classes from
it.uniroma3.mat.extendedset.intsetpackage are designed for concurrent access, those volatiles are harmful for performance and misleading for readers.