Conversation
- FindLibFFI.cmake: add Windows search paths (vcpkg, choco, LIBFFI_ROOT) - FindLibTCC.cmake: add Windows search paths (TCC_ROOT, C:/tcc) - FindLibClang.cmake: add Windows search paths (LLVM_ROOT, Program Files/LLVM) - InstallLibTCC.cmake: fix MSVC configure and build steps - tcc_build_msvc.bat: helper script for TCC build on MSVC Refs: metacall#458
Member
|
Have you tested it? |
Member
|
I cannot merge it.. it breaks all the indentation and it just doesn't work. Test it on your fork until it works before PRing it here. |
Author
Hi, I understand the issue with indentation. I will fix it and reopen the PR. Sorry for the inconvenience. |
Member
|
PR when you have tested it on your fork and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
C Loader had no Windows support in CMake find modules - all search paths were Linux-only.
Changes
FindLibFFI.cmake: add Windows search paths (LIBFFI_ROOT, vcpkg, choco, scoop)FindLibTCC.cmake: add Windows search paths (TCC_ROOT, C:/tcc)FindLibClang.cmake: add Windows search paths (LLVM_ROOT, Program Files/LLVM)InstallLibTCC.cmake: fix MSVC configure and build stepstcc_build_msvc.bat: helper script for TCC build on MSVCResult
c_loader.dllsuccessfully builds on Windows x64 with MSVC 19.42Tested with
Refs: #458