Skip to content

[lexical-playground] Chore: Fix AutocompleteNode importDOM warning - #7667

Merged
etrepum merged 1 commit into
meta:mainfrom
etrepum:autocompletenode-warning
Jul 3, 2025
Merged

etrepum merged 1 commit into
meta:mainfrom
etrepum:autocompletenode-warning

Conversation

@etrepum

@etrepum etrepum commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Description

Since #7659 fixed the code that generates importDOM warnings we now have a new warning for AutocompleteNode's lack of importDOM in the playground. This fixes that warning.

Test plan

Before

AutocompleteNode should implement "importDOM" if using a custom "exportDOM" method to ensure HTML serialization (important for copy & paste) works as expected

After

No warning

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Jul 3, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@vercel

vercel Bot commented Jul 3, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 2:40pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 2:40pm

@etrepum
etrepum added this pull request to the merge queue Jul 3, 2025
Merged via the queue into meta:main with commit 42ddfa1 Jul 3, 2025
@etrepum etrepum mentioned this pull request Jul 3, 2025
@etrepum
etrepum deleted the autocompletenode-warning branch September 29, 2025 15:34

This branch was successfully deployed

2 active deployments
Preview – lexical-playground — 3048c443 Deployed Jul 3, 2025 by vercel[bot]
Preview – lexical — 3048c443 Deployed Jul 3, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants