Skip to content

[lexical-react] Bug Fix: aria-prohibited-attr violation on LexicalContentEditableElement - #7647

Merged
etrepum merged 3 commits into
meta:mainfrom
so99ynoodles:ISSUE-7500
Jun 30, 2025
Merged

etrepum merged 3 commits into
meta:mainfrom
so99ynoodles:ISSUE-7500

Conversation

@so99ynoodles

@so99ynoodles so99ynoodles commented Jun 25, 2025 •

Copy link
Copy Markdown
Contributor

Description

Describe the changes in this pull request

  • removing role in read-only editor leads to an a11y violation aria-prohibited-attr

Closes #7500

Test plan

  • add jest-axe for a11y check

Before

npm run test-unit packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx

image

After

npm run test-unit packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx

image

@vercel

vercel Bot commented Jun 25, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2025 1:07am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2025 1:07am

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @so99ynoodles!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@etrepum etrepum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes other tests to fail

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Jun 25, 2025
@etrepum

etrepum commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

I think this looks fine but maybe @zurfyx should take a look

@etrepum
etrepum added this pull request to the merge queue Jun 30, 2025
Merged via the queue into meta:main with commit 388c85a Jun 30, 2025
@etrepum etrepum mentioned this pull request Jul 3, 2025
fantactuka pushed a commit that referenced this pull request Aug 11, 2025

This branch was successfully deployed

2 active deployments
Preview – lexical-playground — 55486d5b Deployed Jun 26, 2025 by vercel[bot]
Preview – lexical — 55486d5b Deployed Jun 26, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: role="textbox" should be preserved in read-only mode

3 participants