Repository navigation
[ci] Chore: Upgrade astro to fix mysterious integration test failure - #7196
Merged
Merged
Conversation
etrepum
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
February 18, 2025 04:29
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
added
extended-tests
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
I guess it must just be some kind of poisoned cache in the other #7117 PR but I don't really have sufficient privileges to investigate further (or just try and reset the cache). I've disabled the test in that PR, we're not currently getting a lot of value out of it but it would be nice to have examples with other frameworks at some point. |
ivailop7
approved these changes
Feb 18, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
astro integration test strangely started failing. Locally it seems that the server would just hang on requests instead of serving them. Looks like it might've been the --no-package-lock usage, which was intended to make sure we were testing a recent version of the frameworks under test, but it's not really worth the hassle on our end to have that setting.
Test plan
Before
Integration tests would fail for no good reason (e.g. https://github.com/facebook/lexical/actions/runs/13383012921/job/37374781282)
After
Integration tests pass again