Repository navigation
Conversation
saint1991
requested review from
acywatson,
fantactuka,
thegreatercurve,
trueadm,
tylerjbainbridge and
zurfyx
as code owners
November 18, 2022 16:08
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 19, 2022 23:31
b2ff592 to
331736d
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 01:57
331736d to
6d28fe6
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 06:21
6d28fe6 to
1ab7037
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 06:47
1ab7037 to
e82f98f
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 08:04
e82f98f to
24ec420
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 08:43
24ec420 to
7c460ba
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 09:14
7c460ba to
700e710
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 12:19
78695b4 to
d211c0d
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 13:00
d211c0d to
6061134
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 13:19
6061134 to
91fca7f
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 20, 2022 14:27
91fca7f to
f046c76
Compare
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 21, 2022 14:53
f4c3793 to
329c183
Compare
saint1991
changed the title
saint1991
changed the title
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 23, 2022 14:28
329c183 to
bea80c4
Compare
saint1991
changed the title
saint1991
force-pushed
the
feature/meta-codehighlightnode
branch
from
November 23, 2022 14:32
bea80c4 to
114feaa
Compare
Contributor
|
Thanks for the contribution @saint1991! Unfortunately, I don't think this is really needed any more with the introduction of allowing users to replace core nodes themselves #3367. This should give you the ability to create your own node from CodeNode and then add in any additional serialisable data. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokenize process sometimes produces some other metadata than the token type.
For example, which 2 tokens are pair of braces.
To enable keeping such information at CodeHighlightNode adds a field to hold serializable metadata.
TODO