Repository navigation
Expose Tokenizer interface to accept custom tokenizer other than Prism at @lexical/code - #3243
Merged
Merged
Conversation
saint1991
requested review from
acywatson,
fantactuka,
thegreatercurve,
trueadm,
tylerjbainbridge and
zurfyx
as code owners
October 23, 2022 01:35
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
saint1991
commented
Oct 23, 2022
Contributor
Author
There was a problem hiding this comment.
To keep compatibility, add tokenizer as an optional argument.
If it is not specified, PrismTokenizer will be used like before (at line 693).
saint1991
commented
Oct 23, 2022
Contributor
Author
There was a problem hiding this comment.
Tokenizer implementation using Prism that is the same as the original implementation and this will be used as default.
saint1991
force-pushed
the
feature/custom-tokenizer
branch
from
October 23, 2022 03:22
ee56a5a to
97cccc8
Compare
…m at @lexical/code
saint1991
force-pushed
the
feature/custom-tokenizer
branch
from
October 23, 2022 05:18
97cccc8 to
f79d550
Compare
Contributor
|
Much needed PR! |
|
This will be perfect, I want to use other code highlight than Prism! |
acywatson
approved these changes
Oct 24, 2022
fantactuka
approved these changes
Oct 24, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
…m at @lexical/code (#3243)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism has powerful functionality to handle various languages including custom language,
but some other tools like ANTLR have their own grammar definition and parser generator.
This PR exposes the Tokenizer interface at
registerCodeHighlightingin @lexical/code plugin to handle such a case.