Skip to content

Feature: Improve $wrapLeafNodesInElements's input parameter createElement #2557

Closed
Closed
Feature: Improve $wrapLeafNodesInElements's input parameter createElement#2557
Labels
enhancementImprovement over existing feature

Description

@aquarius-wing
aquarius-wing
opened on Jun 29, 2022

I need createElement parameter turn to (targetNode: LexicalNode) => ElementNode

Because I have some node with custom properties just like a paragraph with pinOnMap, when I want it turn to heading, the pinOnMap property is lost.

I need targetNode in createElement function's input parameters list, so I can read it and set to new node.

Activity

  1. aquarius-wing
    added
    enhancementImprovement over existing feature
    on Jun 29, 2022

  2. thegreatercurve commented on Nov 24, 2022

    @thegreatercurve
    thegreatercurve
    on Nov 24, 2022
    Contributor

    Nice idea @aquarius-wing! Would you be interested in creating this in a PR?

  3. zurfyx commented on Apr 12, 2023

    @zurfyx
    zurfyx
    on Apr 12, 2023
    Member

    Closing as this function is now obsolete

  4. zurfyx
    closed this as completedon Apr 12, 2023

  5. GermaVinsmoke commented on Apr 12, 2024

    @GermaVinsmoke
    GermaVinsmoke
    on Apr 12, 2024

    @zurfyx Can you please let us know what was it replaced with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprovement over existing feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions