Repository navigation
Add set_control_value and delete_control - #94
Merged
Merged
Conversation
RussTedrake
force-pushed
the
delete_control
branch
from
August 28, 2021 20:27
4c975c2 to
df77b26
Compare
RussTedrake
changed the title
Before, we can create controls with the command set_control, but had no way update their value remotely nor to delete them.
RussTedrake
force-pushed
the
delete_control
branch
from
August 28, 2021 22:05
df77b26 to
f973d12
Compare
rdeits
approved these changes
Aug 29, 2021
rdeits
left a comment
rdeits
left a comment
Collaborator
There was a problem hiding this comment.
Looks good--thanks for adding the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we can create controls with the command set_control, but had no way to delete them.