Call end block function in each cosmos modules

[antho1404]

The EndBlocker of the module was not called by the module and also these EndBlock for each module were not called because of a wrong initialization of the app.

[krhubert]

Hum end blocker is empty in each module. What is the point of calling it?

[antho1404]

Making sure that it's called when we need it, I was experimenting with the pagination and found this issue

[krhubert]

The EndBlocker of the module was not called by the module and also these EndBlock for each module were not called because of a wrong initialization of the app.

Hum, I'm not sure why this code works and how, but EndBlock is empty and dose nothing in each module.

Also you have change BeginBlockers order which on which I'm not sure if they are good.
If you take a look on cosmos/sdk-tutorial , the line is missing is in fact:

  app.mm.SetOrderBeginBlockers(distr.ModuleName, slashing.ModuleName)
  >>> app.mm.SetOrderEndBlockers(staking.ModuleName)

So I would rather add only this one and check if its' working.

[antho1404]

I just reverted the modification on the begin/end order. Now the PR just call the EndBlocker. Not something critical as it is not called anymore but at least it's ready when we want to call it.

[NicolasMahe]

i don't think this PR is necessary but it doesn't cause any new issue, so i'm good with merging it

[krhubert]

What about calling Order explicit like we disscuss?

I'm ok to merge this one too, although as @NicolasMahe point it's not necessary. Also if you want to be consistent you should call BeginBlock as well :P

[antho1404]

I just wanted to revert it and maybe put it in another PR as it creates too much discussion and I want to try to have more details about that.
BeginBlock calls BeginBlocker correctly in all the modules, only the EndBlocker was not called.
I agree it's not a "necessary" PR for now but I was playing with the end of blocks and got stuck for a long time because of this bug so if it helps for next time not being stuck for nothing it's good isn't it? This is still a bug as a function of our module is never called and will never be called without this fix.