CONV-092: Persist selected target format in component state#99
Merged
menvil merged 1 commit intoMay 31, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONV-092 — Persist Selected Target Format In Component State
Stabilizes
selectedTargetFormat/targetFormatErroracross remove/replace and re-selection so stale target state can't leak into a new file flow.Changes
resetTargetSelection()helper; call it fromresetCurrentUpload()so removing/replacing the file clearsselectedTargetFormatandtargetFormatError.selectTargetFormat()already clearstargetFormatErrorat entry, so a previous error is cleared once a valid target is chosen.Tests
composer test(192),composer lint,npm run buildall pass.🤖 Generated with Claude Code
Summary by cubic
Persist and correctly reset the selected target format so old selections and errors never carry into a new file when removing or replacing uploads. Addresses CONV-092 by stabilizing target selection across file changes.
resetTargetSelection()and call it fromresetCurrentUpload()to clearselectedTargetFormatandtargetFormatErroron remove/replace.selectTargetFormat()clearstargetFormatErroronce a valid target is chosen.Written for commit b3034d6. Summary will update on new commits.