Skip to content

CONV-092: Persist selected target format in component state#99

Merged
menvil merged 1 commit into
developfrom
feature/CONV-092-persist-selected-target-format-in-component-state
May 31, 2026
Merged

CONV-092: Persist selected target format in component state#99
menvil merged 1 commit into
developfrom
feature/CONV-092-persist-selected-target-format-in-component-state

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-092 — Persist Selected Target Format In Component State

Stabilizes selectedTargetFormat/targetFormatError across remove/replace and re-selection so stale target state can't leak into a new file flow.

Changes

  • Add resetTargetSelection() helper; call it from resetCurrentUpload() so removing/replacing the file clears selectedTargetFormat and targetFormatError.
  • (Existing) selectTargetFormat() already clears targetFormatError at entry, so a previous error is cleared once a valid target is chosen.

Tests

  • Selected target resets when the file is removed / replaced.
  • Target error clears when a valid target is chosen after an invalid one.

composer test (192), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Persist and correctly reset the selected target format so old selections and errors never carry into a new file when removing or replacing uploads. Addresses CONV-092 by stabilizing target selection across file changes.

  • Bug Fixes
    • Added resetTargetSelection() and call it from resetCurrentUpload() to clear selectedTargetFormat and targetFormatError on remove/replace.
    • Ensured selectTargetFormat() clears targetFormatError once a valid target is chosen.

Written for commit b3034d6. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdfc8393-d9a6-4278-a927-244d7df5e00c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-092-persist-selected-target-format-in-component-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 112b3cf into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-092-persist-selected-target-format-in-component-state branch May 31, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant