Skip to content

CONV-091: Implement target format selection#98

Merged
menvil merged 1 commit into
developfrom
feature/CONV-091-implement-target-format-selection
May 31, 2026
Merged

CONV-091: Implement target format selection#98
menvil merged 1 commit into
developfrom
feature/CONV-091-implement-target-format-selection

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-091 — Implement Target Format Selection

Implements the selectTargetFormat() handler the CONV-090 tests were written against (un-skips them).

Changes

  • Add selectedTargetFormat and targetFormatError state.
  • selectTargetFormat($targetFormat): looks up the converter via ConverterRegistry::find(source, target). On success sets selectedTargetFormat and moves to the settings step; on no match shows "This conversion is not supported yet." and stays on format; if the current file is gone, returns to upload.
  • Add a settings step placeholder ("Settings for PNG to JPG … added in Phase 8"). No options schema rendered.
  • Render targetFormatError on the format step.
  • No ConversionJob is created (Phase 9).

Tests

  • Un-skipped CONV-090 tests now pass: supported selection → settings placeholder; unsupported → format step + error.

composer test (189), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Implements target format selection in the dashboard (Linear CONV-091).
Looks up a converter via the registry, advances to a settings placeholder on success, shows "This conversion is not supported yet." on unsupported targets, returns to upload if the file is missing, and unskips CONV-090 tests which now pass.

Written for commit 8bde46f. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26c11011-2cda-42af-a0da-6a4bc45aa217

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-091-implement-target-format-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 9d654db into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-091-implement-target-format-selection branch May 31, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant