CONV-091: Implement target format selection#98
Merged
menvil merged 1 commit intoMay 31, 2026
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONV-091 — Implement Target Format Selection
Implements the
selectTargetFormat()handler the CONV-090 tests were written against (un-skips them).Changes
selectedTargetFormatandtargetFormatErrorstate.selectTargetFormat($targetFormat): looks up the converter viaConverterRegistry::find(source, target). On success setsselectedTargetFormatand moves to thesettingsstep; on no match shows "This conversion is not supported yet." and stays onformat; if the current file is gone, returns toupload.settingsstep placeholder ("Settings for PNG to JPG … added in Phase 8"). No options schema rendered.targetFormatErroron the format step.Tests
composer test(189),composer lint,npm run buildall pass.🤖 Generated with Claude Code
Summary by cubic
Implements target format selection in the dashboard (Linear CONV-091).
Looks up a converter via the registry, advances to a settings placeholder on success, shows "This conversion is not supported yet." on unsupported targets, returns to upload if the file is missing, and unskips CONV-090 tests which now pass.
Written for commit 8bde46f. Summary will update on new commits.