Skip to content

CONV-090: Test target format selection#97

Merged
menvil merged 1 commit into
developfrom
feature/CONV-090-test-target-format-selection
May 31, 2026
Merged

CONV-090: Test target format selection#97
menvil merged 1 commit into
developfrom
feature/CONV-090-test-target-format-selection

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-090 — Test Target Format Selection

Adds the (test-first) Livewire tests for target-format selection in tests/Feature/Livewire/DashboardConverterTargetFormatTest.php:

  • Selecting a supported target (pngjpg) sets selectedTargetFormat and moves to the settings placeholder.
  • Selecting an unsupported target (mp3) is rejected, stays on the format step, and shows an error.

TDD note

Both tests were verified red locally against the absent selectTargetFormat() handler (Public method [selectTargetFormat] not found). They are marked ->skip('Implemented in CONV-091') so this per-task PR merges green; CONV-091 removes the skips and implements the behavior.

composer test (189; 2 skipped), composer lint pass.

🤖 Generated with Claude Code


Summary by cubic

Add test-first Livewire tests for target-format selection in tests/Feature/Livewire/DashboardConverterTargetFormatTest.php (CONV-090).
They verify pngjpg advances to settings and mp3 is rejected with an error; tests are skipped until CONV-091 implements the handler.

Written for commit 259dd0e. Summary will update on new commits.

Review in cubic

Add Livewire tests for supported/unsupported target selection.
Verified red against the absent selectTargetFormat() handler, then
marked skip pending CONV-091 to keep the suite green for merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c3496504-49c3-481e-a856-39e52d6fdefe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-090-test-target-format-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit c4fe063 into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-090-test-target-format-selection branch May 31, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant