CONV-090: Test target format selection#97
Merged
Conversation
Add Livewire tests for supported/unsupported target selection. Verified red against the absent selectTargetFormat() handler, then marked skip pending CONV-091 to keep the suite green for merge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONV-090 — Test Target Format Selection
Adds the (test-first) Livewire tests for target-format selection in
tests/Feature/Livewire/DashboardConverterTargetFormatTest.php:png→jpg) setsselectedTargetFormatand moves to the settings placeholder.mp3) is rejected, stays on the format step, and shows an error.TDD note
Both tests were verified red locally against the absent
selectTargetFormat()handler (Public method [selectTargetFormat] not found). They are marked->skip('Implemented in CONV-091')so this per-task PR merges green; CONV-091 removes the skips and implements the behavior.composer test(189; 2 skipped),composer lintpass.🤖 Generated with Claude Code
Summary by cubic
Add test-first Livewire tests for target-format selection in
tests/Feature/Livewire/DashboardConverterTargetFormatTest.php(CONV-090).They verify
png→jpgadvances to settings andmp3is rejected with an error; tests are skipped until CONV-091 implements the handler.Written for commit 259dd0e. Summary will update on new commits.