Skip to content

CONV-085: Load available target formats#92

Merged
menvil merged 1 commit into
developfrom
feature/CONV-085-load-available-target-formats
May 31, 2026
Merged

CONV-085: Load available target formats#92
menvil merged 1 commit into
developfrom
feature/CONV-085-load-available-target-formats

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-085 — Load Available Target Formats

Loads the available conversion targets for the current FileRecord from ConverterRegistry and renders them on the format step (minimal render; full cards in CONV-087).

Changes

  • Add availableTargets computed property on DashboardConverter returning ConverterRegistry::targetsFor(currentFile->extension) (empty when no current file).
  • Replace the Phase-7 placeholder on the format step with a registry-driven target list (Convert PNG to + label/description per target). No hardcoded target list.

Tests

  • PNG file shows JPG/WEBP/PDF targets.
  • JPG file shows PNG/WEBP/PDF targets.
  • No current file → empty target list.
  • Updated two upload tests that asserted the old placeholder text.

composer test (181), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-085 by loading available target formats from ConverterRegistry based on the current file and showing them on the format step. Replaces the placeholder with a dynamic, registry-driven list.

  • New Features
    • Added availableTargets on DashboardConverter to return ConverterRegistry::targetsFor(currentFile->extension) (empty when no file).
    • Updated the format step UI to display “Convert {EXT} to” with each target’s label and description (no hardcoded formats).

Written for commit eb4438f. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 3c0b160 into develop May 31, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aefa195b-112d-4ff0-833a-fb0b51dd1983

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-085-load-available-target-formats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-085-load-available-target-formats branch May 31, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant