Skip to content

CONV-043: Create OptionsValidator skeleton#56

Merged
menvil merged 1 commit into
developfrom
feature/CONV-043-create-options-validator-skeleton
May 28, 2026
Merged

CONV-043: Create OptionsValidator skeleton#56
menvil merged 1 commit into
developfrom
feature/CONV-043-create-options-validator-skeleton

Conversation

@menvil

@menvil menvil commented May 28, 2026

Copy link
Copy Markdown
Owner

Adds OptionsValidator skeleton (depends on OptionsSchemaValidator) and InvalidConverterOptionsException. Validation logic in CONV-045.


Summary by cubic

Implements CONV-043 by scaffolding OptionsValidator and defining InvalidConverterOptionsException. Sets up the validation layer pending CONV-045 and the OptionsSchemaValidator.

  • New Features
    • Added OptionsValidator with DI for OptionsSchemaValidator and a validate($schema, $options) method (currently throws LogicException).
    • Added InvalidConverterOptionsException with helpers for unknown, required, and invalid option values.
    • Added a basic unit test to resolve the validator from the container and confirm the validate method exists.

Written for commit 3fe2184. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@menvil menvil merged commit c1a8303 into develop May 28, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e30c6330-c449-47ae-a798-27af7f21f7ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-043-create-options-validator-skeleton

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-043-create-options-validator-skeleton branch May 28, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant