Skip to content

CONV-042: Implement options schema validator#55

Merged
menvil merged 1 commit into
developfrom
feature/CONV-042-implement-options-schema-validator
May 28, 2026
Merged

CONV-042: Implement options schema validator#55
menvil merged 1 commit into
developfrom
feature/CONV-042-implement-options-schema-validator

Conversation

@menvil

@menvil menvil commented May 28, 2026

Copy link
Copy Markdown
Owner

Implements OptionsSchemaValidator with supported types, key/label requirements, duplicate detection, and select/segmented options enforcement.


Summary by cubic

Implements an options schema validator with clear errors and strict rules for fields, types, and choice options. Fulfills CONV-042 by validating converter option schemas.

  • New Features
    • Validates each field is an array and requires key, type, and label.
    • Supports types: select, segmented, toggle, color, number, range.
    • Detects duplicate field keys.
    • For select/segmented, requires non-empty options with value and non-empty label.
    • Adds InvalidOptionsSchemaException with specific reasons for failures.

Written for commit d924ee3. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6618e25d-69a3-4214-ae8f-04292abc7287

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-042-implement-options-schema-validator

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit f365861 into develop May 28, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-042-implement-options-schema-validator branch May 28, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant