Skip to content

CONV-039: Implement registry lookup methods#52

Merged
menvil merged 1 commit into
developfrom
feature/CONV-039-implement-registry-lookup-methods
May 28, 2026
Merged

CONV-039: Implement registry lookup methods#52
menvil merged 1 commit into
developfrom
feature/CONV-039-implement-registry-lookup-methods

Conversation

@menvil

@menvil menvil commented May 28, 2026

Copy link
Copy Markdown
Owner

Implements all/forSource/find/targetsFor on ConverterRegistry with FileFormat normalization.


Summary by cubic

Implements lookup methods in ConverterRegistry to list and find converters, with FileFormat normalization for consistent matching. Addresses Linear CONV-039 by enabling reliable source/target queries.

  • New Features
    • all(): returns all registered converters.
    • forSource(source): normalizes source and filters converters by source format.
    • find(source, target): normalizes formats and returns the matching converter or null.
    • targetsFor(source): returns ConverterTarget entries for a normalized source (with recommended: false).

Written for commit 7aa00e7. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@menvil menvil merged commit d0f9a42 into develop May 28, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d170f34a-760d-449b-ad39-42a5a0456e92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-039-implement-registry-lookup-methods

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-039-implement-registry-lookup-methods branch May 28, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant